Gpgpuimgui #707

devshgraphicsprogramming · 2024-07-10T10:48:43Z

Description

Testing

TODO list:

…call

…appers, update examples_tests submodule

…pping into vertex shader - TODO: fill clipping plane distances

…sl and spirv_intrinsics/core.hlsl because of microsoft/DirectXShaderCompiler#6751

…e it

…ipeline barier to change the font image's layout after the buffer update from TRANSFER_DST_OPTIMAL to READ_ONLY_OPTIMAL

…ngine for this purpose with full test suite. Enter runtime issues, I think it's because of how I currently share resources across modules and the fact ImGUI context is static

…into gpgpuimgui

devshgraphicsprogramming · 2024-07-10T10:50:21Z

include/nbl/ext/ImGui/ImGui.h

 core::smart_refctd_ptr<video::IDescriptorPool> m_descriptorPool;
 core::smart_refctd_ptr<video::IGPUDescriptorSet> m_gpuDescriptorSet;


these are super weird to belong to ImGUI

src/nbl/ext/ImGui/ImGui.cpp

devshgraphicsprogramming · 2024-07-10T10:51:45Z

src/nbl/ext/ImGui/ImGui.cpp

- smart_refctd_ptr<IGPUDescriptorSetLayout> UI::CreateDescriptorSetLayout()
+ smart_refctd_ptr<IGPUDescriptorSetLayout> UI::createDescriptorSetLayout()
 {
- nbl::video::IGPUDescriptorSetLayout::SBinding bindings[] = {
+ nbl::video::IGPUDescriptorSetLayout::SBinding bindings[] = 
+ {
 {
- .binding = 0,
+ .binding = 0u,


as the user to provide a descriptor set layout, also as what binding Ix holds the textures we'll index

…ate memory corruption issues. Make NITE work, now we just need to take care of imguizmo which doesn't like the configuration

src/nbl/ext/ImGui/ImGui.cpp

devshgraphicsprogramming · 2024-07-10T10:52:37Z

src/nbl/ext/ImGui/ImGui.cpp

+ void UI::createDescriptorPool()
 {
- static constexpr int TotalSetCount = 1;
 IDescriptorPool::SCreateInfo createInfo = {};
- createInfo.maxDescriptorCount[static_cast<uint32_t>(asset::IDescriptor::E_TYPE::ET_COMBINED_IMAGE_SAMPLER)] = TotalSetCount;
+ createInfo.maxDescriptorCount[static_cast<uint32_t>(asset::IDescriptor::E_TYPE::ET_COMBINED_IMAGE_SAMPLER)] = 1u;
+ createInfo.maxDescriptorCount[static_cast<uint32_t>(asset::IDescriptor::E_TYPE::ET_STORAGE_BUFFER)] = 1u;


user shall be in charge of this

devshgraphicsprogramming · 2024-07-10T10:55:23Z

src/nbl/ext/ImGui/ImGui.cpp

 }
 tQueue->endCapture();

 auto & io = ImGui::GetIO();
 io.DisplaySize = ImVec2(m_window->getWidth(), m_window->getHeight());
 io.DisplayFramebufferScale = ImVec2(1.0f, 1.0f);

- m_vertexBuffers.resize(maxFramesInFlight);
- m_indexBuffers.resize(maxFramesInFlight);
+ m_mdiBuffers.resize(maxFramesInFlight);


when you'll use StreamingTransientDataBufferST for the mdiBuffer, you can forget about maxFramesInFlight

devshgraphicsprogramming · 2024-07-10T10:56:01Z

src/nbl/ext/ImGui/ImGui.cpp

+ bool UI::render(IGPUCommandBuffer* commandBuffer, const uint32_t frameIndex)
 {
+ const bool validFramesRange = frameIndex >= 0 && frameIndex < maxFramesInFlight;


using StreamingTransientDataBufferST for the mdi buffers will free you from having to ask for the frameIndex

btw also take SIntededSubmit instead of just commandBuffer then you'll be able to handle overflows nicely and also steal the signalSemaphores to latch the free of the mdiBuffer allocation upon a frame completion

we agreed we remove SIntededSubmit from the render method due to overflow & non-dynamic renderpass issues

devshgraphicsprogramming · 2024-07-10T10:58:19Z

src/nbl/ext/ImGui/ImGui.cpp

+ core::vector2df_SIMD scale;
+ core::vector2df_SIMD translate;


use nbl::hlsl::float32_t2 types

src/nbl/ext/ImGui/ImGui.cpp

devshgraphicsprogramming · 2024-07-10T11:01:37Z

src/nbl/ext/ImGui/ImGui.cpp

+ VkRect2D scissor[] = { {.offset = {(int32_t)viewport.x, (int32_t)viewport.y}, .extent = {(uint32_t)viewport.width, (uint32_t)viewport.height}} };
+ commandBuffer->setScissor(scissor); // cover whole viewport (only to not throw validation errors)


just create a pipeline without any scissors (its in the pipeline creation parameters)

you cannot because currently we hardcode dynamic state - VK_DYNAMIC_STATE_SCISSOR as well

ask user for the number of dynamic scissors that will be used for the Graphics Pipeline

src/nbl/ext/ImGui/shaders/fragment.hlsl

devshgraphicsprogramming · 2024-07-10T11:11:49Z

tools/nite/main.cpp

+ for (auto i = 0u; i < m_maxFramesInFlight; i++)
+ {
+ if (!m_cmdPool)
+ return logFail("Couldn't create Command Pool!");
+ if (!m_cmdPool->createCommandBuffers(IGPUCommandPool::BUFFER_LEVEL::PRIMARY, { m_cmdBufs.data() + i, 1 }))
+ return logFail("Couldn't create Command Buffer!");
+ }


you should probably create all commandbuffers at once

we agreed to fix/update/adjust the nite in the next PR

devshgraphicsprogramming · 2024-07-10T11:16:26Z

tools/nite/main.cpp

+ const auto resourceIx = m_realFrameIx % m_maxFramesInFlight;
+
+ if (m_realFrameIx >= m_maxFramesInFlight)
+ {
+ const ISemaphore::SWaitInfo cbDonePending[] =
+ {
+ {
+ .semaphore = m_semaphore.get(),
+ .value = m_realFrameIx + 1 - m_maxFramesInFlight
+ }
+ };
+ if (m_device->blockForSemaphores(cbDonePending) != ISemaphore::WAIT_RESULT::SUCCESS)
+ return;
+ }


I think some surgery between two examples went wrong.

The new examples use m_submitIx to advance the semaphore each time the main render submission is done.

and here you're doing some sync based on m_realFrameIx instead

we agreed to fix/update/adjust the nite in the next PR

…fig header on fly with CMake and share across imgui projects. TODO: add NBL_IMGUI_WITH_TEST_ENGINE enabled by default which makes all imgui projects use our configuration with embedding the test engine and enables the nite tool, otherwise disables stuff and limits the imgui build to minimum

…e and use running modes

…buffer themselves & validate its creation params, memory, allocate + mapping flags, update examples_tests submodule

… minimum (remove optional delta in secs, 1/60 by default), get rid of our IWindow & ICursor dependency from the UI, move ImGui::Render() from .update to .render, update examples_tests submodule

…ter multi_allocate, don't try to map MDI memory range in case its unmapped at .render

devshgraphicsprogramming · 2024-09-10T10:43:17Z

src/nbl/ext/ImGui/ImGui.cpp

@@ -816,7 +816,7 @@ namespace nbl::ext::imgui

 auto mdiBuffer = smart_refctd_ptr<IGPUBuffer>(m_mdi.streamingTDBufferST->getBuffer());
 {
- std::chrono::steady_clock::time_point timeout(std::chrono::seconds(0x45));
+ auto timeout(std::chrono::steady_clock::now() + std::chrono::seconds(1u));


still should be MILISECONDS

… required usage buffer flags, increase minStreamingBufferAllocationSize to 32u

…akes, also the design for the subscriber could be better however lets leave it currently

…econds

…the constructor, do also another clean-up, put stuff into nice creation parameters struct, remove unnecessary font adjusting static method + a few IO variables we were setting to their default values anyway, add more comments for users, update examples_tests submodule

devshgraphicsprogramming · 2024-09-14T13:23:22Z

include/nbl/ext/ImGui/ImGui.h

+
+ struct S_CREATION_PARAMETERS
+ {
+ video::IUtilities* const utilities; //! required


for image upload?

yes+ I like the fact I already have device + logger there

…into gpgpuimgui

…s deflate dependency, it should never look system wide but download

…CHLSLCompiler

…ve NSC from the ImGUI extension build system & embed shader sources instead (leave some comments), codegen & compile shaders on fly with respect to new optional S_RESOURCE_PARAMETERS (leave user freedom to specify set & resource bindings with certain required constraints), add more validation to the UI creation, update examples_tests submodule

…XTURES_BINDING, NBL_SAMPLER_STATES_BINDING, NBL_RESOURCES_COUNT & NBL_RESOURCES_SET. Validate external descriptor set layout if given (redirects, validate required textures & samplers binding), support generating default one if nullptr passed. Add more comments for API usage, update examples_tests submodule

…recording non-dynamic renderpass - bring back command buffer + add semaphore wait info for deferred memory deallocation, clean more code, add comments regarding linear allocator TODO, update examples_tests submodule

…tin/hlsl/glsl_compat/core.hlsl

…yout with pipeline layout in the creation parameters, update examples_tests submodule

…module

…into gpgpuimgui

…cator host allocator + LinearAddressAllocatorST sub-allocator combo & use allocator type traits to handle them, update examples_tests submodule, leave some TODO comments

AnastaZIuk added 10 commits July 5, 2024 18:34

Upgrade Nabla's IMGUI extension backend to use indirect indexed draw …

d8a1f1f

…call

update IMGUI to LTS version 1.90.9

fd11a0e

clean a bit Nabla IMGUI extension backend, remove a lot of useless wr…

85d5681

…appers, update examples_tests submodule

Remove SSBO & use Buffer Device Address instead. Clean code, move cli…

c921b9f

…pping into vertex shader - TODO: fill clipping plane distances

comment out matrix inverse & unpackSnorm2x16 from glsl_compat/core.hl…

b995627

…sl and spirv_intrinsics/core.hlsl because of microsoft/DirectXShaderCompiler#6751

handle imgui clipping correctly, introduce emulated_snorm16_t2 and us…

e6ecff6

…e it

eliminate some Nabla IMGUI extension validation errors, auto submit p…

55031d9

…ipeline barier to change the font image's layout after the buffer update from TRANSFER_DST_OPTIMAL to READ_ONLY_OPTIMAL

add 3rdparty/imgui_test_engine submodule

1bdb902

Create Nabla Imgui Test Engine Tool - integrate 3rdparty/imgui_test_e…

fcca8e0

…ngine for this purpose with full test suite. Enter runtime issues, I think it's because of how I currently share resources across modules and the fact ImGUI context is static

Merge branch 'master' of github.com:Devsh-Graphics-Programming/Nabla …

1ce0776

…into gpgpuimgui